Hannah-Jiang commented on a change in pull request #11243:
URL: https://github.com/apache/beam/pull/11243#discussion_r450656496



##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,28 @@ golang {
   }
 }
 
+// this is a workaround to call generateLicenseReport task from project root 
directory.
+// generateLicenseReport does not return correct dependency list when not 
called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+  workingDir project.rootProject.projectDir
+  commandLine './sdks/java/container/license_scripts/license_script.sh'
+}
+
+//command: ./gradlew generateLicenseReport
+import com.github.jk1.license.render.*
+licenseReport {
+  outputDir = 'java_third_party_licenses'
+  projects = [project.rootProject] + project.rootProject.subprojects
+  excludeOwnGroup = true
+  configurations = ALL

Review comment:
       I tried with `runtime` at first, and it detected way less dependencies 
than `ALL`. To be safe (with legal issues), I changed the setting to `ALL`.
   
   I noticed that multiple different versions are detected for some 
dependencies. I checked several of them and they all looked correct. Does the 
issue go away if you change the setting to `runtime`? How did you notice the 
issue? (the licenses were not pulled automatically so you have to add links 
manually?) I am asking this to see if there is an easy way to check unrelated 
dependencies/versions are detected.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to