chamikaramj commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r451184245
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
windowing = transform_node.transform.get_windowing(transform_node.inputs)
step.add_property(
PropertyNames.SERIALIZED_FN,
- self.serialize_windowing_strategy(windowing))
+ self.serialize_windowing_strategy(windowing,
self._default_environment))
Review comment:
Can we always assume default environment here ? What about x-lang
WindowingStrategies ? Probably this can be tested by running a x-lang GBK test
with Dataflow with a WindowingStrategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
