aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655211272
> > Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments: > > https://github.com/apache/beam/blob/1fbc55e7819187018c2cb3cb295eb84e6f348d8a/sdks/python/apache_beam/options/pipeline_options.py#L319-L320 > > > > I'm not really sure why that is but it's been there for three years so I'm a little hesitant to remove it... I just pushed [982e087](https://github.com/apache/beam/commit/982e087fd09509277057b76991598cad3e6acf8e) that does this, let's see if it breaks anything in CI or Google tests. > > I'll check back in the morning, if it breaks anything (or if anyone tells me this is a bad idea), I can re-write the test to only assert on specific options. > > I do not remember the reason for this. I am looking. > > @tvalentyn - do you remember? I _believe_ default value of RuntimeValueProviders are actually user provided non-default values. (If I am reading this correctly: https://github.com/apache/beam/blob/1fbc55e7819187018c2cb3cb295eb84e6f348d8a/sdks/python/apache_beam/options/pipeline_options.py#L115) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
