danielxjd commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451554555
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -793,6 +795,14 @@ public void deleteDataset(String projectId, String
datasetId)
String.format(
"BigQuery insertAll error, retrying: %s",
ApiErrorExtractor.INSTANCE.getErrorMessage(e)));
+ GoogleJsonError.ErrorInfo errorInfo =
getErrorInfo(e);
+ if (errorInfo == null) {
+ return insert.execute().getInsertErrors();
Review comment:
I have changed it to throw the exception directly and changed the
corresponding unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
