agrawal-siddharth commented on code in PR #24447:
URL: https://github.com/apache/beam/pull/24447#discussion_r1037393102
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -681,7 +681,7 @@ private static void fieldDescriptorFromTableField(
new BigDecimal((String) value));
} else if (value instanceof BigDecimal) {
return
BigDecimalByteStringEncoder.encodeToBigNumericByteString(((BigDecimal) value));
- } else if (value instanceof Double || value instanceof Float) {
Review Comment:
I have reduced the scope of the change by simply adding Integer and Long
alonside Double and Float.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -681,7 +681,7 @@ private static void fieldDescriptorFromTableField(
new BigDecimal((String) value));
} else if (value instanceof BigDecimal) {
return
BigDecimalByteStringEncoder.encodeToBigNumericByteString(((BigDecimal) value));
- } else if (value instanceof Double || value instanceof Float) {
Review Comment:
I have reduced the scope of the change by simply adding Integer and Long
alongside Double and Float.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
