xinyuiscool commented on PR #24276:
URL: https://github.com/apache/beam/pull/24276#issuecomment-1335793383
Thanks for fixing the problem for #1 in my previous comments. However, seems
some of the necessary changes are also reverted for #2. I expect passing a
mapping {stateId -> storeId} (currently it's a set of stateId) to the
```SamzaStoreStateInternals.createStateInternalsFactory()```. Then
createStateInternalsFactory() can use that information to create the
```stores``` map. Somehow this logic is missing. It was present in your
previous code. Please take a look and run ./gradlew :runners:samza:build to
verify the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
