apilloud commented on a change in pull request #12214:
URL: https://github.com/apache/beam/pull/12214#discussion_r452556681
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlStdOperatorMappingTable.java
##########
@@ -29,127 +29,620 @@
/** SqlStdOperatorMappingTable. */
@Internal
public class SqlStdOperatorMappingTable {
+
+ /**
+ * Keep this list in sync with
+ *
https://github.com/google/zetasql/blob/master/zetasql/public/builtin_function.proto.
Uncomment
Review comment:
We have historically avoided the pattern of blocks of commented out
constants. I don't have a strong opinion if this is short term, but
@kennknowles might.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
