damondouglas commented on PR #24630: URL: https://github.com/apache/beam/pull/24630#issuecomment-1351882696
> Note that WriteFiles supports a lot of additional properties like dynamic destinations, no spilling, ... that users typically want. They are pretty easy to add since they are just boilerplate builder stuff. Your call if you want to add them now or later. @lukecwik I'm glad you suggested this as it inspired me to remove fields shared between CsvIO.Write and FileIO.Write and instead just maintain an inner instance of FileIO.Write. For example, CsvIO.Write's withCompression calls the inner instance of FileIO.Write's withCompression instead of maintaining a redundant compression property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
