robertwb commented on code in PR #24735:
URL: https://github.com/apache/beam/pull/24735#discussion_r1054707417
##########
sdks/python/apache_beam/utils/python_callable.py:
##########
@@ -106,6 +106,19 @@ def load_from_script(source):
exec('\n'.join(lines), exec_globals)
return exec_globals[name]
+ def default_label(self):
+ src = self._source.strip()
+ last_line = src.split('\n')[-1]
+ if last_line[0] != ' ' and len(last_line) < 72:
Review Comment:
An arbitrary limit for "this is getting to big to show on one line." We
wouldn't want unboundedly-large stage names with huge chunks of source code in
them, but if it's small like "lambda x: 2 * x" that's nice.
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -832,6 +833,9 @@ def from_runner_api_parameter(
def fn_takes_side_inputs(fn):
+ if isinstance(fn, python_callable.PythonCallableWithSource):
+ # This can be removed once support for *args and **kwargs is implemented.
Review Comment:
Done.
##########
sdks/python/apache_beam/typehints/trivial_inference.py:
##########
@@ -314,6 +315,9 @@ def infer_return_type(c, input_types, debug=False, depth=5):
isinstance(input_types[1], Const)):
from apache_beam.typehints import opcodes
return opcodes._getattr(input_types[0], input_types[1].value)
+ elif isinstance(c, python_callable.PythonCallableWithSource):
+ # This can be removed once support for *args and **kwargs is implemented.
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
