lukecwik commented on code in PR #24803:
URL: https://github.com/apache/beam/pull/24803#discussion_r1058968138
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java:
##########
@@ -506,9 +506,9 @@ public abstract List<SubscriptionPath>
listSubscriptions(ProjectPath project, To
*/
public abstract boolean isEOF();
- /** Create {@link com.google.api.services.pubsub.model.Schema} from resource
path. */
+ /** Create {@link com.google.api.services.pubsub.model.Schema} from Schema
definition content. */
public abstract void createSchema(
Review Comment:
Unfortunately PubsubClient has been around for several years.
Marking with `@Internal` makes sense and can be done in a follow-up. There
are likely several classes in here that should be updated and we could add a
note in `CHANGES.md` that we annotated classes with `@Internal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
