TSultanov commented on code in PR #24816:
URL: https://github.com/apache/beam/pull/24816#discussion_r1059042296
##########
playground/backend/internal/db/datastore/datastore_db_test.go:
##########
@@ -439,6 +443,9 @@ func TestDatastore_GetCatalog(t *testing.T) {
t.Errorf("GetCatalog() error = %v, wantErr %v",
err, tt.wantErr)
}
if err == nil {
+ if len(catalog) != 1 {
Review Comment:
I don't think that making a separate test makes much sense here - it will
have exactly the same prepare function and the assertion case is quite simple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
