[GitHub] [beam] je-ik commented on a change in pull request #12155: [BEAM-10400] Fix race condition in DirectRunner watermark update

[GitBox]

je-ik commented on a change in pull request #12155:
URL: https://github.com/apache/beam/pull/12155#discussion_r453501114



##########
File path: 
runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
##########
@@ -1110,17 +1109,7 @@ public void updateWatermarks(
     pendingUpdates.offer(
         PendingWatermarkUpdate.create(
             executable, completed, timerUpdate, unprocessedInputs, outputs, 
earliestHold));
-    tryApplyPendingUpdates();
-  }
-
-  private void tryApplyPendingUpdates() {
-    if (refreshLock.tryLock()) {
-      try {
-        applyNUpdates(MAX_INCREMENTAL_UPDATES);
-      } finally {
-        refreshLock.unlock();
-      }
-    }

Review comment:
       Agree, I misread the code, there is force apply of all updates triggered 
from `EvaluationContext#extractFiredTimers()`, which is correct. My tests still 
pass even after returning this code back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org