JozoVilcek commented on code in PR #24837:
URL: https://github.com/apache/beam/pull/24837#discussion_r1062646379
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/MultiDoFnFunction.java:
##########
@@ -180,14 +186,14 @@ public TimerInternals timerInternals() {
DoFnRunnerWithMetrics<InputT, OutputT> doFnRunnerWithMetrics =
new DoFnRunnerWithMetrics<>(stepName, doFnRunner, metricsAccum);
- return new SparkProcessContext<>(
+ SparkProcessContext<Object, InputT, OutputT> ctx =
+ new SparkProcessContext<>(
Review Comment:
It actually can not be put into constructor, because processor is
responsible for providing correct instance of output manager which is needed
doFnRunner construction. Therefore I did choose to wrap these into container
and pass to processor as context object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
