Abacn opened a new pull request, #24910: URL: https://github.com/apache/beam/pull/24910
Fixes #24870 * Fixes portable and not-yet-standard logical type get deserialized to UnknownLogicalType **Please** add a meaningful description for your change here This was broken by #23014 in particular, prior to the change, SchemaTransform sets the URN all logical types not yet STANDARD to URN_BEAM_LOGICAL_JAVASDK when translating to proto https://github.com/apache/beam/blob/release-2.42.0/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java#L183 after the change, it keeps URNs of portable logical types. This enables translating them from another SDK. https://github.com/apache/beam/blob/release-2.43.0/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java#L176 But, when translating back, the code here did not change: https://github.com/apache/beam/blob/f9a86e5e2e3bbb345dad0953d7fe6a6b8ffe7a68/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java#L417 Causing the deserializing not attempted and reduced to UnknownLogicalType Unfortunately Schema containing logical type with same URN but different class is not considered equal and is not caught by the unit test SchemaTranslationTest.FromProtoToProtoTest <- this could be a followup fix ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
