yyy1000 commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1374317578
> Suppose a={1, null}, b={2, null} so they have same size, previously a != b
but now a equals b because value and otherValue are both null.
>
> This is not get caught by unit test so we need to improve our test imo.
Sorry for missing that.
I think there are no duplicated null checks in the code now, so maybe no
changes could be made for that. :)
We can close this PR and the original issue.
Should I add a unit test for " a={1, null}, b={2, null} " or no need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
