Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065065491
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args}
--pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
To me like with current change there isn't a test suite hitting `$status1 ==
5 && $status2 == 5` still, is that wrong? Still sounds not good to me to ignore
not test running. I had experiences on running some local tests but did not
feed the test with needed args and triggered `@ignore`. Currently I get warned
by this clause.
If there is a test job that hitting this clause, one can fix that special
case by sth like `sh run_pytest.sh ... || [[ $? == 5 ]] `to allow return code 5
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args}
--pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Looks like with current change there isn't a test suite hitting `$status1 ==
5 && $status2 == 5` still, is that wrong? Still sounds not good to me to ignore
not test running. I had experiences on running some local tests but did not
feed the test with needed args and triggered `@ignore`. Currently I get warned
by this clause.
If there is a test job that hitting this clause, one can fix that special
case by sth like `sh run_pytest.sh ... || [[ $? == 5 ]] `to allow return code 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
