robinyqiu commented on a change in pull request #12174: URL: https://github.com/apache/beam/pull/12174#discussion_r453995996
########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java ########## @@ -156,7 +156,14 @@ public void unparseCall( break; case OTHER_FUNCTION: String funName = call.getOperator().getName(); - if (FUNCTIONS_USING_INTERVAL.contains(funName)) { + if (funName.equals("numeric_literal")) { + // self-designed function Review comment: Also, could you move this logic to a function `unparseNumericLiteralWrapperFunction()` like we do in other branches? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org