jrmccluskey commented on code in PR #25054:
URL: https://github.com/apache/beam/pull/25054#discussion_r1073717517
##########
sdks/python/apache_beam/typehints/typehints_test.py:
##########
@@ -1610,5 +1610,27 @@ def test_pipe_operator_as_union(self):
native_type_compatibility.convert_to_beam_type(type_b))
+class TestBuiltinsTyping(unittest.TestCase):
+
+ def _assert_equal_convert_to_beam_type(self, type_a, type_b):
+ beam_type_a = native_type_compatibility.convert_to_beam_type(type_a)
Review Comment:
The proper way to handle this is to enable the unit tests and the behavior
only on Python 3.9 and higher. #24986 does this for the added unit test cases,
so this should be okay to do here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
