lukecwik commented on code in PR #24967:
URL: https://github.com/apache/beam/pull/24967#discussion_r1082963768
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java:
##########
@@ -214,59 +174,14 @@ protected BatchDataflowWorker(
this.memoryMonitor = MemoryMonitor.fromOptions(options);
this.statusPages =
- WorkerStatusPages.create(
- DEFAULT_STATUS_PORT, this.memoryMonitor,
sdkHarnessRegistry::sdkHarnessesAreHealthy);
+ WorkerStatusPages.create(DEFAULT_STATUS_PORT, this.memoryMonitor, ()
-> true);
Review Comment:
The existing implementation would be considered healthy if there were any
SDK harnesses. In the case of the legacy-worker (aka Java production runner) it
would use an empty SDK harness registry which always returned true:
https://github.com/apache/beam/blob/4ffeae4d2b800f2df36d2ea2eab549f2204d5691/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SdkHarnessRegistries.java#L265
Instead of removing this feature I feel as though in the future this health
check could rely on an actual attribute which is why I left it with this
trivial lambda.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
