KevinGG commented on a change in pull request #12249:
URL: https://github.com/apache/beam/pull/12249#discussion_r454545613
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -556,19 +556,26 @@ def _process(self, pcoll):
if not self._pin._user_pipeline:
# Retrieve a reference to the user defined pipeline instance.
self._pin._user_pipeline = user_pcoll.pipeline
- # Once user_pipeline is retrieved, check if the user pipeline
- # contains any source to cache. If so, current cache manager held
- # by current interactive environment might get wrapped into a
- # streaming cache, thus re-assign the reference to that cache
- # manager.
+ # Retrieve a reference to the cache manager for the user defined
+ # pipeline instance.
+ self._pin._cache_manager = ie.current_env().get_cache_manager(
Review comment:
L569 might not get executed at all if the `background_caching_job` does
not `has_source_to_cache`. This line makes sure the cache manager is
initialized (if never initialized before) in either conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
