ZijieSong946 commented on a change in pull request #12174: URL: https://github.com/apache/beam/pull/12174#discussion_r454663699
########## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java ########## @@ -805,6 +807,24 @@ private RexNode convertSimpleValueToRexNode(TypeKind kind, Value value) { .makeLiteral( value.getStringValue(), typeFactory().createSqlType(SqlTypeName.VARCHAR), true); break; + case TYPE_NUMERIC: + // Cannot simply call makeExactLiteral() for ZetaSQL NUMERIC type because later it will be Review comment: Make sense. Maybe a design doc is needed for detailed illustration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org