mynameborat commented on code in PR #25265:
URL: https://github.com/apache/beam/pull/25265#discussion_r1093675113
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaMetricsBundleProgressHandler.java:
##########
@@ -148,7 +151,10 @@ private void
parseAndUpdateMetric(MetricsApi.MonitoringInfo monitoringInfo) {
break;
default:
- LOG.warn("Unsupported metric type {}", monitoringInfo.getType());
+ if (LOG.isDebugEnabled()) {
Review Comment:
IMO, this check is overkill as the log message itself is not constructing
complex statements (string)? I think it is better to just do `LOG.debug`
Additionally it is just more readable than this additional branching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
