alexeyinkin commented on code in PR #24957:
URL: https://github.com/apache/beam/pull/24957#discussion_r1105813875
##########
playground/frontend/lib/components/dropdown_button/dropdown_button.dart:
##########
@@ -154,7 +157,7 @@ class _AppDropdownButtonState extends
State<AppDropdownButton>
color: Theme.of(context).backgroundColor,
borderRadius: BorderRadius.circular(kMdBorderRadius),
),
- child: widget.createDropdown(_close),
+ child: child,
Review Comment:
`chlid` had been creating multiple times here by `OverlayEntry` builder
leading to false positive analytics events.
##########
playground/frontend/Dockerfile:
##########
@@ -28,6 +28,7 @@ RUN apt-get update && apt-get install -y wget xz-utils git
RUN wget
https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_$FLUTTER_VERSION-stable.tar.xz
&&\
tar -xf flutter_linux_$FLUTTER_VERSION-stable.tar.xz &&\
mv flutter /opt/ &&\
+ git config --global --add safe.directory /opt/flutter &&\
Review Comment:
The recent version of Debian 11.6 has newer `git` that by default does not
allow operations outside of home directories. Flutter uses `git` to download
dependencies when it is ran for the first time, so this is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
