yyy1000 commented on code in PR #25203:
URL: https://github.com/apache/beam/pull/25203#discussion_r1107909513
##########
sdks/go/pkg/beam/core/funcx/sideinput_test.go:
##########
@@ -39,6 +39,7 @@ func TestIsIter(t *testing.T) {
{func(*typex.EventTime, *int, *string) bool { return false },
false}, // EventTimes disallowed
{func(*int, *typex.Y, *typex.Z) bool { return false }, false},
// too many values
{func(*typex.EventTime, *int, *typex.Y, *typex.Z) bool { return
false }, false}, // too many values, EventTimes disallowed
+ {func(any) bool { return false }, false},
// any is not allowed as a param
Review Comment:
😫So sorry for that.
I have fixed it.
Another question is: can 'emit function' take both pointer and non-pointer
as params? If it can, I will add test cases for *any and any in output_test.go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
