ibzib commented on a change in pull request #12259:
URL: https://github.com/apache/beam/pull/12259#discussion_r456073212
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -240,13 +256,31 @@ class BeamDataframeDoctestRunner(doctest.DocTestRunner):
"""A Doctest runner suitable for replacing the `pd` module with one backed
by beam.
"""
- def __init__(self, env, use_beam=True, **kwargs):
+ def __init__(self, env, use_beam=True, skip=None, **kwargs):
self._test_env = env
+
+ def to_callable(cond):
+ if cond == '*':
Review comment:
Should we support regex matching here, or is that overkill?
##########
File path: sdks/python/apache_beam/dataframe/doctests_test.py
##########
@@ -63,6 +63,20 @@
ignored result
'''
+ERROR_RAISING_NAME_ERROR_TESTS = '''
+>>> import apache_beam
+>>> raise apache_beam.dataframe.frame_base.WontImplementError('anything')
+ignored exception
+>>> raise NameError
+ignored exception
+>>> undefined_name
+ignored exception
+>>> 2 + 2
Review comment:
Why should running one line successfully reset `_seen_wont_implement`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
