cushon commented on code in PR #25578:
URL: https://github.com/apache/beam/pull/25578#discussion_r1119455183
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java:
##########
@@ -177,7 +178,9 @@ static RowSelector createRowSelector(SchemaAndDescriptor
schemaAndDescriptor) {
return builder
.visit(new
AsmVisitorWrapper.ForDeclaredMethods().writerFlags(ClassWriter.COMPUTE_FRAMES))
.make()
- .load(Row.class.getClassLoader(),
ClassLoadingStrategy.Default.INJECTION)
+ .load(
+
ReflectHelpers.findClassLoader(schemaAndDescriptor.getClass().getClassLoader()),
+ getClassLoadingStrategy(schemaAndDescriptor.getClass()))
Review Comment:
I'm going to go ahead and revert this change, tentatively resolving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
