damccorm commented on PR #25650: URL: https://github.com/apache/beam/pull/25650#issuecomment-1448257817
> Can we pin tox to 3.x.x while installing during the release process and investigate what happened with tox 4.x and gen_protos.py? The release process currently relies on whatever value of tox is installed on the system (which for most will be whatever got installed by https://github.com/apache/beam/blob/62e9a1239bb6f9ef2f1469d0c1af192697f8b10c/local-env-setup.sh#L126 - I think we should investigate as part of our work to upgrade to tox 4.x, but I don't think that should block this change which unblocks the release process while we're doing that investigation. There's not an easy way to pin tox to 3.x.x without unnecessarily changing the user's environment. > Other tox related tasks might be affected(we might need to run gen_protos before every tox task). Now I strongly opinionated to do https://github.com/apache/beam/pull/25650#issuecomment-1447278793 This is not a problem during the rest of the release process, and we don't have a single place to force everyone to tox 4.x.x AFAIK --------------------------------------- To summarize: this shouldn't be our permanent fix, but I think it is a good standin until we have a real fix. Since a real fix isn't our top priority and we could be without it for another release or so (which is fine), I think we should take this to unblock the release for future people running the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
