lukecwik commented on a change in pull request #12275:
URL: https://github.com/apache/beam/pull/12275#discussion_r456682773
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -735,7 +733,44 @@ def invoke_process(self,
else:
self._invoke_process_per_window(
windowed_value, additional_args, additional_kwargs)
- return None
+ return residuals
+
+ def _should_process_window_for_sdf(
+ self,
+ windowed_value, # type: WindowedValue
+ additional_kwargs,
+ window_index=None, # type: Optional[int]
+ ):
+ restriction_tracker = self.invoke_create_tracker(self.restriction)
Review comment:
I don't want to hold the splitting lock while the user methods are being
invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
