twang126 commented on code in PR #25935:
URL: https://github.com/apache/beam/pull/25935#discussion_r1145272138
##########
sdks/python/apache_beam/yaml/yaml_transform.py:
##########
@@ -377,6 +378,18 @@ def pipeline_as_composite(spec):
return dict(spec, name=None, type='composite')
+def normalize_source_sink(spec):
Review Comment:
Having it plural and requiring a list makes sense to me. I think that swap
to multiple sinks and sources will be inevitable. In my experience multiple
sources were unusual, but it was actually fairly common to want multiple sinks
(typically one for an online store and another to an offline store).
Requiring a list can be annoying for the YAML user who just wants a singular
source and sink, but imo a list of size 1 is actually not too much overhead vs.
just a single element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
