TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r458065291



##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -205,7 +205,7 @@ if [[ $confirmation = "y" ]]; then
   sha512sum -c apache-beam-${RELEASE}.tar.gz.sha512
 
   echo "-----Signing Source Release apache-beam-${RELEASE}.tar.gz-----"
-  gpg --local-user ${SIGNING_KEY} --armor --detach-sig 
apache-beam-${RELEASE}.zip
+  gpg --local-user ${SIGNING_KEY} --armor --detach-sig 
apache-beam-${RELEASE}.tar.gz

Review comment:
       I kept .zip but also added .taz.gz  . Can only one type of source 
archive exist?
   In this particular line I change it because .tar.gz should be here as it is 
in echo above, but .zip was signed twice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to