AnandInguva commented on code in PR #26120: URL: https://github.com/apache/beam/pull/26120#discussion_r1158617490
########## sdks/python/container/base_image_requirements_manual.txt: ########## @@ -32,11 +32,11 @@ cython<1 # some versions of libraries that launch Beam pipelines, like tensorflow-transform. # Leaving 'future' in our containers for now prevent breaking tft users. future -guppy3 # Memory profiler +guppy3;python_version<"3.11" # Memory profiler mmh3 # Optimizes execution of some Beam codepaths. TODO: Make it Beam's dependency. nltk # Commonly used for natural language processing. nose==1.3.7 # For Dataflow internal testing. TODO: remove this. -python-snappy # Optimizes execution of some Beam codepaths. +python-snappy;python_version<"3.11" # Optimizes execution of some Beam codepaths. Review Comment: ```suggestion # TODO: Uncomment python version once python-snappy supports it. # https://github.com/apache/beam/issues/25985 python-snappy;python_version<"3.11" # Optimizes execution of some Beam codepaths. ``` ########## sdks/python/container/base_image_requirements_manual.txt: ########## @@ -32,11 +32,11 @@ cython<1 # some versions of libraries that launch Beam pipelines, like tensorflow-transform. # Leaving 'future' in our containers for now prevent breaking tft users. future -guppy3 # Memory profiler +guppy3;python_version<"3.11" # Memory profiler Review Comment: ```suggestion # TODO: Uncomment python version once guppy supports it. # https://github.com/apache/beam/issues/25984 guppy3;python_version<"3.11" # Memory profiler ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
