rshamunov commented on code in PR #25117:
URL: https://github.com/apache/beam/pull/25117#discussion_r1158644282
##########
playground/terraform/infrastructure/cloudbuild-manual-setup/01.setup/variables.tf:
##########
@@ -16,12 +16,20 @@
# under the License.
variable "project_id" {
- type = string
description = "The ID of the Google Cloud project within which resources are
provisioned"
}
-variable "cloudbuild_service_account_id" {
- type = string
- description = "The ID of the cloud build service account responsible for
provisioning Google Cloud resources"
- default = "playground-cloudbuild-sa"
+variable "pg_cloudbuild_deployer_sa_name" {
+ description = "The ID of the cloud build service account responsible for
deploying the Playground"
+ default = "pg-cloudbuild-deployer-sa"
}
+
+variable "pg_cloudbuild_helm_updater_sa_name" {
+ description = "The ID of the cloud build service account responsible for
updating the Helm"
+ default = "pg-cloudbuild-updater-sa"
+}
+
+variable "playground_cloudbuild_updater_sa_name" {
+ description = "The ID of the cloud build service account responsible for
running CI/CD checks and scripts"
+ default = "pg-cloudbuild-cicd-runner-sa"
Review Comment:
CI and CD completely different triggers with different permission
requirements. We need a dedicated trigger for CI and for CD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
