nickuncaged1201 commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1173143659
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -118,12 +166,14 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
.build())
.build()))
.apply(
- MapElements.into(TypeDescriptors.rows())
- .via(
- seqMess ->
- valueMapper.apply(
-
seqMess.getMessage().getData().toByteArray())))
- .setRowSchema(beamSchema));
+ ParDo.of(new ErrorFn("Read-Error-Counter",
valueMapper))
Review Comment:
Can you change the metric name to use format "IO
name"-"read/write"-error-counter. Something like PubSubLite-read-error-counter
Keeping the same format makes it a bit easier on me later to capture them in
our backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
