brucearctor commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1181907470
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1059,12 +1058,11 @@ message StandardCoders {
// Logical types understood by all SDKs should be defined in schema.proto.
// Example of well known logical types:
// beam:logical_type:schema:v1
- // - Representation type: BYTES
+ // - Representation type: BYTE
Review Comment:
Doesn't seem related to the purpose of the PR -- but OK anyways
##########
sdks/python/apache_beam/utils/annotations_test.py:
##########
@@ -101,51 +100,6 @@ def fnc_test_deprecated_without_since_custom_should_fail():
fnc_test_deprecated_without_since_custom_should_fail()
assert not w
- def test_experimental_with_current_message(self):
- with warnings.catch_warnings(record=True) as w:
-
- @experimental(current='multiply', extra_message='Do this')
- def fnc_test_experimental_with_current_message():
- return 'lol'
Review Comment:
lol
##########
sdks/python/apache_beam/utils/annotations.py:
##########
@@ -192,10 +190,4 @@ def inner(*args, **kwargs):
# 'current' will be optional in both deprecated and experimental
# while 'since' will be mandatory for deprecated.
deprecated = partial(
- annotate, label='deprecated', current=None, extra_message=None)
-experimental = partial(
- annotate,
- label='experimental',
- current=None,
- since=None,
- extra_message=None)
+ annotate, label='deprecated', current=None, extra_message=None)
Review Comment:
do we not care about newlines at end of file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
