kennknowles commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1183085334
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowProfilingOptions.java:
##########
@@ -18,14 +18,12 @@
package org.apache.beam.runners.dataflow.options;
import java.util.HashMap;
-import org.apache.beam.sdk.annotations.Experimental;
import org.apache.beam.sdk.options.Description;
import org.apache.beam.sdk.options.Hidden;
import org.apache.beam.sdk.options.PipelineOptions;
/** Options for controlling profiling of pipeline execution. */
@Description("[Experimental] Used to configure profiling of the Dataflow
pipeline")
Review Comment:
Agree! Thank you.
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1059,12 +1058,11 @@ message StandardCoders {
// Logical types understood by all SDKs should be defined in schema.proto.
// Example of well known logical types:
// beam:logical_type:schema:v1
- // - Representation type: BYTES
+ // - Representation type: BYTE
Review Comment:
Curious and not intended for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
