pabloem commented on a change in pull request #12203:
URL: https://github.com/apache/beam/pull/12203#discussion_r460218999
##########
File path: sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py
##########
@@ -236,7 +236,10 @@ def enter_composite_transform(self, transform_node):
self.visit_transform(transform_node)
def visit_transform(self, transform_node):
- if [o for o in self.outputs if o in transform_node.inputs]:
+ # Internal consumers of the outputs we're overriding are expected.
Review comment:
This is because BQ FIle loads returns a series of pcollections (e.g.
files written, jobs started) - and if the downstream transforms depend on these
outputs, they will not work properly when replacing WriteToBQ with BQSink, so
we error out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
