psolomin commented on code in PR #26666:
URL: https://github.com/apache/beam/pull/26666#discussion_r1191734695
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java:
##########
@@ -615,7 +614,15 @@ public Read
withCustomRateLimitPolicy(RateLimitPolicyFactory rateLimitPolicyFact
return
toBuilder().setRateLimitPolicyFactory(rateLimitPolicyFactory).build();
}
- /** Specifies the maximum number of messages per one shard. */
+ /**
+ * Specifies the maximum number of messages per one shard.
+ *
+ * <p>Note: When using consumers with dedicated throughput (Enhanced
Fan-Out), this capacity
+ * corresponds to the number of in-flight shard events which itself can
contain multiple,
+ * potentially even aggregated records.
+ *
+ * @see {@link #withConsumerArn(String)}
+ */
public Read withMaxCapacityPerShard(Integer maxCapacity) {
Review Comment:
Looks like the line 228 should be updated too:
```
* <p>When EFO is enabled, the following configurations are ignored:
*
* <ul>
* <li>{@link Read#withMaxCapacityPerShard(Integer)} <--- drop this?
* <li>{@link Read#withRequestRecordsLimit(int)}
```
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/EFOShardSubscribersPool.java:
##########
@@ -470,6 +472,10 @@ String getPoolId() {
return poolId;
}
+ public int getMaxCapacityPerShard() {
Review Comment:
```suggestion
int getMaxCapacityPerShard() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
