TheNeuralBit commented on a change in pull request #12384:
URL: https://github.com/apache/beam/pull/12384#discussion_r461683216
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -288,14 +288,15 @@ if [[ $confirmation = "y" ]]; then
mkdir -p ${LOCAL_WEBSITE_REPO}
echo "------------------Building Python Doc------------------------"
- virtualenv ${LOCAL_PYTHON_VIRTUALENV}
- source ${LOCAL_PYTHON_VIRTUALENV}/bin/activate
+ python3 -m venv "${LOCAL_PYTHON_VIRTUALENV}"
+ source "${LOCAL_PYTHON_VIRTUALENV}/bin/activate"
cd ${LOCAL_PYTHON_DOC}
pip install tox
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
+ RELEASE_COMMIT=$(git rev-parse --verify ${RELEASE_BRANCH})
Review comment:
Good catch
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -288,14 +288,15 @@ if [[ $confirmation = "y" ]]; then
mkdir -p ${LOCAL_WEBSITE_REPO}
echo "------------------Building Python Doc------------------------"
- virtualenv ${LOCAL_PYTHON_VIRTUALENV}
- source ${LOCAL_PYTHON_VIRTUALENV}/bin/activate
+ python3 -m venv "${LOCAL_PYTHON_VIRTUALENV}"
Review comment:
Is this approach generally preferred over `virtualenv --python=python3`
(just asking for my own edification)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
