Abacn commented on code in PR #26752:
URL: https://github.com/apache/beam/pull/26752#discussion_r1198088334
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -691,7 +691,7 @@ void postFlush() {
@Nullable
TableSchema updatedTableSchema =
Review Comment:
Possibly refer to StorageApiWritesShardedRecords, beside this code path, it
used a if clause in the outside:
https://github.com/apache/beam/blob/dbefe4f8b0915d4d1bd83f315705efaf0b526d3d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java#L751
would be nice to keep Sharded/Unsharded have similar logic.
there are some other code path involve autoUpdateSchema, while this class
member is completely unused in StorageApiWritesUnShardedRecords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
