lostluck commented on PR #26787: URL: https://github.com/apache/beam/pull/26787#issuecomment-1554814051
@jamesfricker As I said last time for your other PR, this doesn't do what you think it does. https://github.com/apache/beam/pull/26368#issuecomment-1518110203 The `go` directive in a go.mod specifies the minimum version of Go with which the code in the module can be built with. So it says that The Go beam SDK doesn't rely on language features or features of the standard library that were added after 1.19. So unless there's a paired change to make use of features introduced in the 1.20 release, there's no real value in changing this. It also doesn't prevent users from using newer versions of Go (including the patched security releases). Further, the `go` directive only indicates Major.Minor and doesn't specify Patch. To-wit: As specified, this cases a build failure, caught by our build system (and would have been caught if it had been built locally too) ``` go: errors parsing go.mod: /home/runner/work/beam/beam/sdks/go.mod:23: invalid go version '1.20.3': must match format 1.23 Error: Process completed with exit code 1. ``` The Go Module reference is quite readable, and explains the `go` directive in detail here: https://go.dev/ref/mod#go-mod-file-go ---- That said, to update the Beam's Infra to use the latest patch, that kind of PR looks like this https://github.com/apache/beam/pull/26054 though for a patch update, only the BeamModulePlugin.groovy and sdks/go/run_with_go_version.sh files would need changes to ensure the latest patch is used. This only affects releases, when they build the boot loader scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
