alexeyinkin commented on code in PR #26978:
URL: https://github.com/apache/beam/pull/26978#discussion_r1214109445
##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
Review Comment:
After the license.
##########
learning/tour-of-beam/frontend/lib/pages/tour/state.dart:
##########
@@ -137,22 +135,27 @@ class TourNotifier extends ChangeNotifier with
PageStateMixin<void> {
if (currentNode is! UnitModel) {
await _emptyPlayground();
} else {
- _setUnitContent(null);
- notifyListeners();
-
- final content = await _unitContentCache.getUnitContent(
- currentSdk.id,
- currentNode.id,
- );
-
- _setUnitContent(content);
- await _unitProgressCache.loadUnitProgress(currentSdk);
- _trySetSnippetType(SnippetType.saved);
- await _loadSnippetByType();
+ await _updateUnitState(currentNode);
}
notifyListeners();
}
+ Future<void> _updateUnitState(NodeModel? currentNode) async {
Review Comment:
I don't see what it does from the name.
##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -49,8 +51,15 @@ void main() {
await _checkContentTreeScrollsProperly(wt);
await _checkHighlightsSelectedUnit(wt);
// TODO(nausharipov): fix tests
- // await _checkRunCodeWorks(wt);
- // await _checkResizeUnitContent(wt);
+ await _checkRunCodeWorks(wt);
+ await _checkResizeUnitContent(wt);
+
+ if (ExamplesLoader.failedToLoadExamples.isNotEmpty) {
+ final tokens = ExamplesLoader.failedToLoadExamples.join(', ');
+ print(
+ 'There are some havent loaded examples with tokens: $tokens',
+ );
+ }
Review Comment:
That's from another task, do not mix it. Especially so since I have changed
this part there. Please isolate the bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
