TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r462965733
##########
File path: .github/workflows/build_wheels.yml
##########
@@ -193,29 +196,232 @@ jobs:
GITHUB_BASE_REF=$GITHUB_BASE_REF
EOF
echo $(cat github_action_info)
- gsutil cp -a public-read github_action_info ${{ env.GCP_PATH }}
+ gsutil cp -a public-read github_action_info ${{
env.GCP_WHEELS_STAGING_PATH }}
- name: Upload GitHub event file to GCS bucket
- run: gsutil cp -a public-read ${GITHUB_EVENT_PATH} ${{ env.GCP_PATH }}
+ run: gsutil cp -a public-read ${GITHUB_EVENT_PATH} ${{
env.GCP_WHEELS_STAGING_PATH }}
list_files_on_gcs:
name: List files on Google Cloud Storage Bucket
- needs: upload_wheels_to_gcs
+ needs: upload_python_sdk_wheels_to_gcs
runs-on: ubuntu-latest
- if: github.repository_owner == 'apache' && github.event_name !=
'pull_request'
+ if: github.repository_owner == 'apache' && (github.event_name == 'push' ||
github.event_name == 'schedule')
steps:
- name: Authenticate on GCP
uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
- name: List file on Google Cloud Storage Bucket
- run: gsutil ls "${{ env.GCP_PATH }}*"
+ run: gsutil ls "${{ env.GCP_WHEELS_STAGING_PATH }}*"
+
+ python_unit_tests:
+ name: 'Python Unit Tests'
+ runs-on: ${{ matrix.os }}
+ if: github.event_name == 'push' || github.event_name == 'schedule'
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ubuntu-latest, windows-latest]
+ params: [
+ {"py_ver": "3.5", "tox_env": "py35"},
+ {"py_ver": "3.6", "tox_env": "py36"},
+ {"py_ver": "3.7", "tox_env": "py37"},
+ ]
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Install python
+ uses: actions/setup-python@v2
+ with:
+ python-version: ${{ matrix.params.py_ver }}
+ - name: Get build dependencies
+ working-directory: ./sdks/python
+ run: python -m pip install -r build-requirements.txt
+ - name: Install tox
+ run: pip install tox
+ - name: Run tests basic unix
+ if: startsWith(matrix.os, 'ubuntu') || startsWith(matrix.os, 'macos')
+ working-directory: ./sdks/python
+ run: tox -c tox.ini -e ${{ matrix.params.tox_env }}
+ - name: Run tests basic windows
+ if: startsWith(matrix.os, 'windows') && (matrix.params.py_ver != '2.7')
Review comment:
Good point. We don't need it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
