ibzib commented on pull request #12385:
URL: https://github.com/apache/beam/pull/12385#issuecomment-666850930


   > I have already spent a long time trying to fix quotes, so I can't help but 
wondering: why do we need flinkCompatibilityMatrixPROCESS in the first place, 
when it is not being run anywhere? If it's important, shouldn't we add it to 
some postcommit?
   
   Another solution I had in mind was reworking the `--environment_config` 
option. JSON blobs are unwieldy, and overloading the `--environment_config` 
option is confusing to the user. We could make each field in the PROCESS 
`--environment_config` blob its own argument, and then reject these arguments 
when `environment_type != PROCESS`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to