SabaSathya commented on code in PR #27256:
URL: https://github.com/apache/beam/pull/27256#discussion_r1245946896
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java:
##########
@@ -97,9 +100,11 @@ FirestoreStub getFirestoreStub(PipelineOptions options) {
.build());
} else {
GcpOptions gcpOptions = options.as(GcpOptions.class);
+ String host = System.getenv().getOrDefault(FIRESTORE_HOST_VARIABLE,
DEFAULT_FIRESTORE_HOST);
+ firestoreOptions.setHost(host);
Review Comment:
Revised to get env or default value only if there is no value in options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
