svetakvsundhar commented on code in PR #27305:
URL: https://github.com/apache/beam/pull/27305#discussion_r1246882852
##########
examples/notebooks/beam-ml/run_inference_multi_model.ipynb:
##########
@@ -65,8 +64,8 @@
{
"cell_type": "markdown",
"source": [
- "A single machine learning model might not be the right solution for
your task. Often, machine learning model tasks involve aggregating mutliple
models together to produce one optimal predictive model and to boost
performance. \n",
- " \n",
+ "A single machine learning model might not be the right solution for
your task. Often, machine learning model tasks involve aggregating mutliple
models together to produce one optimal predictive model and to boost
performance.\n",
Review Comment:
This intro is a bit detailed. Can we add a high level sentence setting the
context; something like "When performing complex tasks like image captioning,
using a single ML model may not be the best solution".
##########
examples/notebooks/beam-ml/run_inference_multi_model.ipynb:
##########
@@ -65,8 +64,8 @@
{
"cell_type": "markdown",
"source": [
- "A single machine learning model might not be the right solution for
your task. Often, machine learning model tasks involve aggregating mutliple
models together to produce one optimal predictive model and to boost
performance. \n",
- " \n",
+ "A single machine learning model might not be the right solution for
your task. Often, machine learning model tasks involve aggregating mutliple
models together to produce one optimal predictive model and to boost
performance.\n",
+ "\n",
"\n",
"This notebook shows how to implement a cascade model in Apache Beam
using the [RunInference
API](https://beam.apache.org/documentation/sdks/python-machine-learning/). The
RunInference API enables you to run your Beam transforms as part of your
pipeline for optimal machine learning inference.\n",
Review Comment:
Can we link to
https://beam.apache.org/documentation/sdks/python-machine-learning/#why-use-the-runinference-api?
##########
examples/notebooks/beam-ml/run_inference_multi_model.ipynb:
##########
@@ -303,15 +268,15 @@
"base_uri": "https://localhost:8080/";
},
"id": "Ud4sUXV2x8LO",
- "outputId": "9e12ea04-a347-426f-8145-280a5676e78b"
+ "outputId": "cc814ff8-d424-4880-e006-56803e0508aa"
},
"execution_count": 2,
"outputs": [
{
"output_type": "stream",
"name": "stdout",
"text": [
- "Error: Failed to call git rev-parse --git-dir --show-toplevel:
\"fatal: not a git repository (or any of the parent directories): .git\\n\"\n",
+ "Error: Failed to call git rev-parse --git-dir: exit status 128
\n",
Review Comment:
nit: add that seeing an error here is normal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
