scwhittle commented on code in PR #27308:
URL: https://github.com/apache/beam/pull/27308#discussion_r1247290763
##########
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java:
##########
@@ -430,21 +449,31 @@ public boolean isReady() {
}
// Measure how long it takes all the logs to appear.
int sleepTime = 0;
- while (values.size() < numEntries) {
+ while (testEntriesObserved.get() < numEntries) {
++sleepTime;
Thread.sleep(1);
}
// Attempt to enter the blocking state by pushing back on the stream,
publishing records and
// then giving them time for it to block.
elementsAllowed.set(false);
- for (int i = 0; i < numEntries; ++i) {
Review Comment:
this wouldn't always trigger blocking since onReady is called every 100 rpc
messages, and each message coudl be a batch of up to 1OK logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
