ahmedabu98 commented on code in PR #24979:
URL: https://github.com/apache/beam/pull/24979#discussion_r1253409820
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1515,11 +1528,43 @@ def process(self, element, *schema_side_inputs):
if not self.with_batched_input:
row_and_insert_id = element[1]
+ row_byte_size = get_deep_size(row_and_insert_id)
+ # maintain buffer byte size for each destination
+ self._destination_buffer_byte_size.setdefault(destination, 0)
+ # send large rows that exceed BigQuery insert limits to DLQ
+ if row_byte_size >= self.max_insert_payload_size:
+ row_mb_size = row_byte_size / 1_000_000
+ max_mb_size = self.max_insert_payload_size / 1_000_000
Review Comment:
This would be true if we are using double slash, which acts as a
`math.floor()` after division. But here we are only using one slash for
division here which will result in a float when necessary (e.g. 500 / 1_000_000
= 0.0005).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
