mkhludnev commented on code in PR #27329:
URL: https://github.com/apache/beam/pull/27329#discussion_r1268540149
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -1118,11 +1118,16 @@ public Builder setOptions(Options.Builder
optionsBuilder) {
/** Return's a field with the give name and type. */
public static Field of(String name, FieldType fieldType) {
+ return of(name, fieldType, Options.none());
+ }
+
+ /** Return's a field with the give name, type and options. */
+ public static Field of(String name, FieldType fieldType, Options options) {
return new AutoValue_Schema_Field.Builder()
.setName(name)
.setDescription("")
.setType(fieldType)
- .setOptions(Options.none())
+ .setOptions(options)
Review Comment:
But carrying options is useful generally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
