hjtran commented on code in PR #27512:
URL: https://github.com/apache/beam/pull/27512#discussion_r1277988523
##########
sdks/python/apache_beam/runners/runner.py:
##########
@@ -158,181 +177,39 @@ def run_pipeline(
# type: (...) -> PipelineResult
"""Execute the entire pipeline or the sub-DAG reachable from a node.
-
- Runners should override this method.
"""
- raise NotImplementedError
+ pipeline.visit(
+ group_by_key_input_visitor(
+ not
options.view_as(TypeOptions).allow_non_deterministic_key_coders)
+ )
+
+ # TODO: https://github.com/apache/beam/issues/19168
+ # portable runner specific default
+ if options.view_as(SetupOptions).sdk_location == 'default':
+ options.view_as(SetupOptions).sdk_location = 'container'
+
+ return self.run_full_pipeline(
Review Comment:
Sorry for crashing, but I got tripped up by this already when writing code
on top of these changes. I think any of `run_portable_pipeline` /
`run_pipeline_proto` / `run_pipeline_from_proto` would be a bit clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
