ahmedabu98 opened a new issue, #27847:
URL: https://github.com/apache/beam/issues/27847

   ### What would you like to happen?
   
   When streaming with STORAGE_WRITE_API, we use the 
[StorageApiWritesShardedRecords](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java)
 path, which splits the messages in terms of the byte size threshold 
(`storageApiAppendThresholdBytes`). However, the record count threshold 
(`storageApiAppendThresholdRecordCount`) is essentially ignored. 
   
   The splitting logic exists in 
[SplittingIterable](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/SplittingIterable.java).
 We should be making a similar check as 
[here](https://github.com/apache/beam/blob/1f90261aef435d947db5eff30172afa3e7d4fd27/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/SplittingIterable.java#L146-L148),
 but for accumulated record count.
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [X] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [X] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to